Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1409ae4 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Fix NULL dereference in kctl-NID mapping in patch_realtek.c 



capsrc_nids can be NULL, and adc_nids should be taken as fallback.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 9e671deb

sound/pci/hda/patch_realtek.c

+4 −1
Original line number Diff line number Diff line
@@ -2517,7 +2517,10 @@ static int alc_build_controls(struct hda_codec *codec) 
	if (!kctl)

		kctl = snd_hda_find_mixer_ctl(codec, "Input Source");

	for (i = 0; kctl && i < kctl->count; i++) {

		err = snd_hda_add_nids(codec, kctl, i, spec->capsrc_nids,

		hda_nid_t *nids = spec->capsrc_nids;

		if (!nids)

			nids = spec->adc_nids;

		err = snd_hda_add_nids(codec, kctl, i, nids,

				       spec->input_mux->num_items);

		if (err < 0)

			return err;