Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1401ac5 authored by Vicky Wallace's avatar Vicky Wallace
Browse files

clk: qcom: Fix clock GPUCC PLL1 crash when call regulator_set_voltage 



GPU_CC_PLL1 is sourced for GFX3D and GMU clock in V2. Therefore
GPU CC PLL1 is probed in GPU CC clock probe and the clock is on
vdd_mx power rail. This change moves get regulator for MX from
GFX clock probe function here.

CRs-Fixed: 2089404
Change-Id: Ibd25b87170999fec27fb24a5f523b10aa3dc5bae
Signed-off-by: default avatarVicky Wallace <vwallace@codeaurora.org>
parent 05e7d36b

drivers/clk/qcom/gpucc-sdm845.c

+13 −12
Original line number Diff line number Diff line
@@ -554,14 +554,14 @@ static struct clk_regmap *gpu_cc_sdm845_clocks[] = { 
	[GPU_CC_GX_GMU_CLK] = &gpu_cc_gx_gmu_clk.clkr,

	[GPU_CC_GX_VSENSE_CLK] = &gpu_cc_gx_vsense_clk.clkr,

	[GPU_CC_PLL_TEST_CLK] = &gpu_cc_pll_test_clk.clkr,

	[GPU_CC_PLL0] = &gpu_cc_pll0.clkr,

	[GPU_CC_PLL1] = NULL,

};



static struct clk_regmap *gpu_cc_gfx_sdm845_clocks[] = {

	[GPU_CC_PLL0] = &gpu_cc_pll0.clkr,

	[GPU_CC_PLL0_OUT_EVEN] = &gpu_cc_pll0_out_even.clkr,

	[GPU_CC_GX_GFX3D_CLK_SRC] = &gpu_cc_gx_gfx3d_clk_src.clkr,

	[GPU_CC_GX_GFX3D_CLK] = &gpu_cc_gx_gfx3d_clk.clkr,

	[GPU_CC_PLL1] = NULL,

};



static const struct qcom_reset_map gpu_cc_sdm845_resets[] = {
@@ -612,8 +612,9 @@ MODULE_DEVICE_TABLE(of, gpu_cc_gfx_sdm845_match_table); 


static void gpu_cc_sdm845_fixup_sdm845v2(struct regmap *regmap)

{

	clk_fabia_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config);

	gpu_cc_sdm845_clocks[GPU_CC_PLL1] = &gpu_cc_pll1.clkr;

	clk_fabia_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config);



	gpu_cc_gmu_clk_src.freq_tbl = ftbl_gpu_cc_gmu_clk_src_sdm845_v2;

	gpu_cc_gmu_clk_src.clkr.hw.init->rate_max[VDD_CX_LOW] = 500000000;

}
@@ -701,15 +702,6 @@ static int gpu_cc_gfx_sdm845_probe(struct platform_device *pdev) 
		return PTR_ERR(regmap);

	}



	/* Get MX voltage regulator for GPU PLL graphic clock. */

	vdd_mx.regulator[0] = devm_regulator_get(&pdev->dev, "vdd_mx");

	if (IS_ERR(vdd_mx.regulator[0])) {

		if (!(PTR_ERR(vdd_mx.regulator[0]) == -EPROBE_DEFER))

			dev_err(&pdev->dev,

				"Unable to get vdd_mx regulator\n");

		return PTR_ERR(vdd_mx.regulator[0]);

	}



	/* GFX voltage regulators for GFX3D  graphic clock. */

	vdd_gfx.regulator[0] = devm_regulator_get(&pdev->dev, "vdd_gfx");

	if (IS_ERR(vdd_gfx.regulator[0])) {
@@ -779,6 +771,15 @@ static int gpu_cc_sdm845_probe(struct platform_device *pdev) 
		return PTR_ERR(vdd_cx.regulator[0]);

	}



	/* Get MX voltage regulator for GPU PLL graphic clock. */

	vdd_mx.regulator[0] = devm_regulator_get(&pdev->dev, "vdd_mx");

	if (IS_ERR(vdd_mx.regulator[0])) {

		if (!(PTR_ERR(vdd_mx.regulator[0]) == -EPROBE_DEFER))

			dev_err(&pdev->dev,

				"Unable to get vdd_mx regulator\n");

		return PTR_ERR(vdd_mx.regulator[0]);

	}



	ret = gpu_cc_sdm845_fixup(pdev, regmap);

	if (ret) {

		dev_err(&pdev->dev, "Failed to do GPU CC clock fixup\n");

include/dt-bindings/clock/qcom,gpucc-sdm845.h

+1 −1
Original line number Diff line number Diff line
@@ -44,6 +44,7 @@ 
#define GPU_CC_GMU_CLK_SRC					26

#define GPU_CC_CX_GFX3D_CLK					27

#define GPU_CC_CX_GFX3D_SLV_CLK					28

#define GPU_CC_PLL0						29



/* GPUCC reset clock registers */

#define GPUCC_GPU_CC_ACD_BCR					0
@@ -55,7 +56,6 @@ 
#define GPUCC_GPU_CC_XO_BCR					6



/* GFX3D clock registers */

#define GPU_CC_PLL0						0

#define GPU_CC_PLL0_OUT_EVEN					1

#define GPU_CC_GX_GFX3D_CLK_SRC					2

#define GPU_CC_GX_GFX3D_CLK					3