Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d0e50e65 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: das16m1: minor cleanup to das16m1_ai_insn_read() 



The (*insn_read) functions return the number of data values read. The 'n'
value is correct but for clarity change the return to 'insn->n'.

For aesthetics, change the 'n' loop variable name to 'i'. That's more common
in comedi drivers.

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b31cf312

drivers/staging/comedi/drivers/das16m1.c

+4 −4
Original line number Diff line number Diff line
@@ -324,11 +324,11 @@ static int das16m1_ai_insn_read(struct comedi_device *dev, 
				unsigned int *data)

{

	int ret;

	int n;

	int i;



	das16m1_ai_set_queue(dev, &insn->chanspec, 1);



	for (n = 0; n < insn->n; n++) {

	for (i = 0; i < insn->n; i++) {

		unsigned short val;



		/* clear interrupt */
@@ -341,10 +341,10 @@ static int das16m1_ai_insn_read(struct comedi_device *dev, 
			return ret;



		val = inw(dev->iobase + DAS16M1_AI_REG);

		data[n] = DAS16M1_AI_TO_SAMPLE(val);

		data[i] = DAS16M1_AI_TO_SAMPLE(val);

	}



	return n;

	return insn->n;

}



static int das16m1_di_insn_bits(struct comedi_device *dev,