Commit d0d97488 authored Nov 29, 2011 by Thomas Meyer Committed by Mauro Carvalho Chehab Dec 30, 2011

[media] uvcvideo: Use kcalloc instead of kzalloc to allocate array

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107



Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 505b534d

drivers/media/video/uvc/uvc_ctrl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1874,7 +1874,7 @@ int uvc_ctrl_init_device(struct uvc_device *dev)
		if (ncontrols == 0)
		continue;

		entity->controls = kzalloc(ncontrols * sizeof(*ctrl),
		entity->controls = kcalloc(ncontrols, sizeof(*ctrl),
		GFP_KERNEL);
		if (entity->controls == NULL)
		return -ENOMEM;