Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d09ca739 authored by Eric Paris's avatar Eric Paris Committed by James Morris
Browse files

security: make LSMs explicitly mask off permissions 



SELinux needs to pass the MAY_ACCESS flag so it can handle auditting
correctly.  Presently the masking of MAY_* flags is done in the VFS.  In
order to allow LSMs to decide what flags they care about and what flags
they don't just pass them all and the each LSM mask off what they don't
need.  This patch should contain no functional changes to either the VFS or
any LSM.

Signed-off-by: default avatarEric Paris <eparis@redhat.com>
Acked-by: default avatarStephen D. Smalley <sds@tycho.nsa.gov>
Signed-off-by: default avatarJames Morris <jmorris@namei.org>
parent 9cfcac81

fs/namei.c

+1 −2
Original line number Diff line number Diff line
@@ -282,8 +282,7 @@ int inode_permission(struct inode *inode, int mask) 
	if (retval)

		return retval;



	return security_inode_permission(inode,

			mask & (MAY_READ|MAY_WRITE|MAY_EXEC|MAY_APPEND));

	return security_inode_permission(inode, mask);

}



/**

security/selinux/hooks.c

+2 −0
Original line number Diff line number Diff line
@@ -2645,6 +2645,8 @@ static int selinux_inode_permission(struct inode *inode, int mask) 
{

	const struct cred *cred = current_cred();



	mask &= (MAY_READ|MAY_WRITE|MAY_EXEC|MAY_APPEND);



	if (!mask) {

		/* No permission to check.  Existence test. */

		return 0;

security/smack/smack_lsm.c

+2 −0
Original line number Diff line number Diff line
@@ -598,6 +598,8 @@ static int smack_inode_rename(struct inode *old_inode, 
static int smack_inode_permission(struct inode *inode, int mask)

{

	struct smk_audit_info ad;



	mask &= (MAY_READ|MAY_WRITE|MAY_EXEC|MAY_APPEND);

	/*

	 * No permission to check. Existence test. Yup, it's there.

	 */