Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d03b65d6 authored by Mitchel Humpherys's avatar Mitchel Humpherys Committed by Patrick Daly
Browse files

iommu/arm-smmu: Make unmapped accesses more obvious 



The fault handler currently spits out a ton of information that can make
clients' eyes glaze over, and understandably so.  One of the most
important pieces of information we obtain from the fault handler is
whether the faulting address is actually mapped (which we check with a
software table walk), but that information is currently not obvious (you
have to know that "soft iova-to-phys=0" means that the software table
walk failed).  Fix this by adding a more obvious error message when we
detect an unmapped access.

Change-Id: Ib95a916baf3e73934642676de4852a550ae0f54b
Signed-off-by: default avatarMitchel Humpherys <mitchelh@codeaurora.org>
Signed-off-by: default avatarPatrick Daly <pdaly@codeaurora.org>
parent d5083c02

drivers/iommu/arm-smmu.c

+4 −0
Original line number Diff line number Diff line
@@ -858,6 +858,10 @@ static irqreturn_t arm_smmu_context_fault(int irq, void *dev) 
				(fsr & 0x80000000) ? "MULTI " : "");

			dev_err(smmu->dev,

				"soft iova-to-phys=%pa\n", &phys_soft);

			if (!phys_soft)

				dev_err(smmu->dev,

					"SOFTWARE TABLE WALK FAILED! Looks like %s accessed an unmapped address!\n",

					dev_name(smmu->dev));

			dev_err(smmu->dev,

				"hard iova-to-phys (ATOS)=%pa\n", &phys_atos);

			dev_err(smmu->dev, "SID=0x%x\n", frsynra);