Commit cf6b1744 authored Oct 24, 2015 by Julia Lawall Committed by Thierry Reding Dec 14, 2015

drm/tegra: dc: Add missing of_node_put()

for_each_matching_node() performs an of_node_get() on each iteration, so
a break out of the loop requires an of_node_put().

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr

):

// <smpl>
@@
local idexpression n;
expression e;
@@

 for_each_matching_node(n,...) {
   ...
(
   of_node_put(n);
|
   e = n
|
+  of_node_put(n);
?  break;
)
   ...
 }
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Thierry Reding <treding@nvidia.com>

parent 986c58d1

drivers/gpu/drm/tegra/dc.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1952,8 +1952,10 @@ static int tegra_dc_parse_dt(struct tegra_dc *dc)
		* cases where only a single display controller is used.
		*/
		for_each_matching_node(np, tegra_dc_of_match) {
		if (np == dc->dev->of_node)
		if (np == dc->dev->of_node) {
		of_node_put(np);
		break;
		}

		value++;
		}