Commit cf5a189d authored Aug 17, 2010 by hiromu Committed by Steven Rostedt Oct 29, 2010

kconfig: Fix missing declaration of variable $dir in streamline_config.pl



On Fri, Aug 17, 2010 at 01:43PM +0800, Américo Wang wrote:
> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
>
> BTW, I think we should add "use strict;" too.

Then I added "use strict;" to streamline_config.pl, I saw another
warning.

> Global symbol "$dir" requires explicit package name at
scripts/kconfig/streamline_config.pl line 286.
> Global symbol "$dir" requires explicit package name at
scripts/kconfig/streamline_config.pl line 287.
> Global symbol "$dir" requires explicit package name at
scripts/kconfig/streamline_config.pl line 288.

Then I added "my $dir;" to line 285.

Cc: Américo Wang <xiyou.wangcong@gmail.com>
Cc: Toralf Foerster <toralf.foerster@gmx.de>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Hiromu Yakura <hiromu1996@gmail.com>
LKML-Reference: <1282042158.7160.9.camel@hiromu-Macbook>

[ changed to just add my in front of $dir instead of new line ]

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

parent ccece60a

scripts/kconfig/streamline_config.pl

+3 −1

Original line number	Diff line number	Diff line
		@@ -42,6 +42,8 @@
		# mv config_strip .config
		# make oldconfig
		#
		use strict;

		my $config = ".config";

		my $uname = `uname -r`;
		@@ -291,7 +293,7 @@ if (defined($lsmod_file)) {
		# see what modules are loaded on this system
		my $lsmod;

		foreach $dir ( ("/sbin", "/bin", "/usr/sbin", "/usr/bin") ) {
		foreach my $dir ( ("/sbin", "/bin", "/usr/sbin", "/usr/bin") ) {
		if ( -x "$dir/lsmod" ) {
		$lsmod = "$dir/lsmod";
		last;