Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cf2c7481 authored by Pete Zaitcev's avatar Pete Zaitcev Committed by Greg Kroah-Hartman
Browse files

[PATCH] USB serial: encapsulate schedule_work, remove double-calling 



I'm going to throw schedule_work away, it's retarded. But for starters,
let's have it encapsulated.

Also, generic and whiteheat were both calling usb_serial_port_softint
and scheduled work. Only one was necessary.

Signed-off-by: default avatarPete Zaitcev <zaitcev@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent ad93375a

drivers/usb/serial/cyberjack.c

+1 −1
Original line number Diff line number Diff line
@@ -469,7 +469,7 @@ static void cyberjack_write_bulk_callback (struct urb *urb, struct pt_regs *regs 


exit:

	spin_unlock(&priv->lock);

	schedule_work(&port->work);

	usb_serial_port_softint(port);

}



static int __init cyberjack_init (void)

drivers/usb/serial/cypress_m8.c

+1 −1
Original line number Diff line number Diff line
@@ -824,7 +824,7 @@ static void cypress_send(struct usb_serial_port *port) 
	priv->bytes_out += count; /* do not count the line control and size bytes */

	spin_unlock_irqrestore(&priv->lock, flags);



	schedule_work(&port->work);

	usb_serial_port_softint(port);

} /* cypress_send */

drivers/usb/serial/empeg.c

+1 −1
Original line number Diff line number Diff line
@@ -335,7 +335,7 @@ static void empeg_write_bulk_callback (struct urb *urb, struct pt_regs *regs) 
		return;

	}



	schedule_work(&port->work);

	usb_serial_port_softint(port);

}

drivers/usb/serial/ftdi_sio.c

+1 −1
Original line number Diff line number Diff line
@@ -1472,7 +1472,7 @@ static void ftdi_write_bulk_callback (struct urb *urb, struct pt_regs *regs) 
		return;

	}



	schedule_work(&port->work);

	usb_serial_port_softint(port);

} /* ftdi_write_bulk_callback */

drivers/usb/serial/garmin_gps.c

+1 −1
Original line number Diff line number Diff line
@@ -1012,7 +1012,7 @@ static void garmin_write_bulk_callback (struct urb *urb, struct pt_regs *regs) 
		garmin_data_p->flags |= CLEAR_HALT_REQUIRED;

	}



	schedule_work(&port->work);

	usb_serial_port_softint(port);

}