Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cdfe4c00 authored by Chunfeng Yun's avatar Chunfeng Yun Committed by Greg Kroah-Hartman
Browse files

usb: xhci: fix TDS for MTK xHCI1.1 



commit 72b663a99c074a8d073e7ecdae446cfb024ef551 upstream.

For MTK's xHCI 1.0 or latter, TD size is the number of max
packet sized packets remaining in the TD, not including
this TRB (following spec).

For MTK's xHCI 0.96 and older, TD size is the number of max
packet sized packets remaining in the TD, including this TRB
(not following spec).

Signed-off-by: default avatarChunfeng Yun <chunfeng.yun@mediatek.com>
Signed-off-by: default avatarMathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e081bd0d

drivers/usb/host/xhci-ring.c

+3 −3
Original line number Diff line number Diff line
@@ -3132,7 +3132,7 @@ static u32 xhci_td_remainder(struct xhci_hcd *xhci, int transferred, 
{

	u32 maxp, total_packet_count;



	/* MTK xHCI is mostly 0.97 but contains some features from 1.0 */

	/* MTK xHCI 0.96 contains some features from 1.0 */

	if (xhci->hci_version < 0x100 && !(xhci->quirks & XHCI_MTK_HOST))

		return ((td_total_len - transferred) >> 10);
@@ -3141,8 +3141,8 @@ static u32 xhci_td_remainder(struct xhci_hcd *xhci, int transferred, 
	    trb_buff_len == td_total_len)

		return 0;



	/* for MTK xHCI, TD size doesn't include this TRB */

	if (xhci->quirks & XHCI_MTK_HOST)

	/* for MTK xHCI 0.96, TD size include this TRB, but not in 1.x */

	if ((xhci->quirks & XHCI_MTK_HOST) && (xhci->hci_version < 0x100))

		trb_buff_len = 0;



	maxp = GET_MAX_PACKET(usb_endpoint_maxp(&urb->ep->desc));