Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cddd74db authored by Wei Yongjun's avatar Wei Yongjun Committed by Wim Van Sebroeck
Browse files

watchdog: pic32-wdt: Fix return value check in pic32_wdt_drv_probe() 



In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Signed-off-by: default avatarWei Yongjun <yongjun_wei@trendmicro.com.cn>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent 919edd51

drivers/watchdog/pic32-wdt.c

+2 −2
Original line number Diff line number Diff line
@@ -183,8 +183,8 @@ static int pic32_wdt_drv_probe(struct platform_device *pdev) 
		return PTR_ERR(wdt->regs);



	wdt->rst_base = devm_ioremap(&pdev->dev, PIC32_BASE_RESET, 0x10);

	if (IS_ERR(wdt->rst_base))

		return PTR_ERR(wdt->rst_base);

	if (!wdt->rst_base)

		return -ENOMEM;



	wdt->clk = devm_clk_get(&pdev->dev, NULL);

	if (IS_ERR(wdt->clk)) {