Commit cd890ade authored Feb 17, 2016 by Fabio Estevam Committed by Mark Brown Feb 17, 2016

ASoC: hdac_hdmi: Remove 'edev' NULL check



Commit 4a3478de ("ASoC: hdac_hdmi: Add jack reporting")
leads to the following Smatch complaint:

sound/soc/codecs/hdac_hdmi.c:971 hdac_hdmi_present_sense()
         warn: variable dereferenced before check 'edev' (see line 967)

As explained by Subhransu S. Prusty:

"This NULL check is not required, can be removed.

edev object is expected to be present when the present_sense is
called. This is called from places where this edev object is
already available."

So remove the evdev NULL check.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Acked-by: Subhransu S. Prusty <subhransu.s.prusty@intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 478f544e

sound/soc/codecs/hdac_hdmi.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -968,9 +968,6 @@ static void hdac_hdmi_present_sense(struct hdac_hdmi_pin *pin, int repoll)
		struct hdac_hdmi_pcm *pcm;
		int val;

		if (!edev)
		return;

		pin->repoll_count = repoll;

		pm_runtime_get_sync(&edev->hdac.dev);