Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd888cee authored by Zhang Qilong's avatar Zhang Qilong Committed by Greg Kroah-Hartman
Browse files

spi: img-spfi: fix reference leak in img_spfi_resume 



[ Upstream commit ee5558a9084584015c8754ffd029ce14a5827fa8 ]

pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in img_spfi_resume, so we should fix it.

Fixes: deba2580 ("spi: Add driver for IMG SPFI controller")
Signed-off-by: default avatarZhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201102145651.3875-1-zhangqilong3@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent ab86255f

drivers/spi/spi-img-spfi.c

+3 −1
Original line number Diff line number Diff line
@@ -771,8 +771,10 @@ static int img_spfi_resume(struct device *dev) 
	int ret;



	ret = pm_runtime_get_sync(dev);

	if (ret)

	if (ret) {

		pm_runtime_put_noidle(dev);

		return ret;

	}

	spfi_reset(spfi);

	pm_runtime_put(dev);