Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cd2e54ca authored by Chris Lew's avatar Chris Lew
Browse files

soc: qcom: glink: smem: Add wmb between data and write index 



Make sure data is flushed before updating write index by adding a wmb.

Change-Id: I3d17ed56b64ac9ca399a0ef11a638027c1ba36ae
Signed-off-by: default avatarChris Lew <clew@codeaurora.org>
parent b14f1bf3

drivers/soc/qcom/glink_smem_native_xprt.c

+11 −0
Original line number Diff line number Diff line
@@ -557,6 +557,12 @@ static int fifo_write(struct edge_info *einfo, const void *data, int len) 
	len = fifo_write_body(einfo, data, len, &write_index);

	if (unlikely(len < 0))

		return len;



	/* All data writes need to be flushed to memory before the write index

	 * is updated. This protects against a race condition where the remote

	 * reads stale data because the write index was written before the data.

	 */

	wmb();

	einfo->tx_ch_desc->write_index = write_index;

	send_irq(einfo);
@@ -599,6 +605,11 @@ static int fifo_write_complex(struct edge_info *einfo, 
	if (unlikely(len3 < 0))

		return len3;



	/* All data writes need to be flushed to memory before the write index

	 * is updated. This protects against a race condition where the remote

	 * reads stale data because the write index was written before the data.

	 */

	wmb();

	einfo->tx_ch_desc->write_index = write_index;

	send_irq(einfo);