Commit cced50c9 authored Jun 14, 2014 by Christoffer Dall

arm/arm64: KVM: vgic: Clear queued flags on unqueue



If we unqueue a level-triggered interrupt completely, and the LR does
not stick around in the active state (and will therefore no longer
generate a maintenance interrupt), then we should clear the queued flag
so that the vgic can actually queue this level-triggered interrupt at a
later time and deal with its pending state then.

Note: This should actually be properly fixed to handle the active state
on the distributor.

Acked-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>

parent dbf20f9d

virt/kvm/arm/vgic.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -667,8 +667,10 @@ static void vgic_unqueue_irqs(struct kvm_vcpu *vcpu)
		* active), then the LR does not hold any useful info and can
		* be marked as free for other use.
		*/
		if (!(lr.state & LR_STATE_MASK))
		if (!(lr.state & LR_STATE_MASK)) {
		vgic_retire_lr(i, lr.irq, vcpu);
		vgic_irq_clear_queued(vcpu, lr.irq);
		}

		/* Finally update the VGIC state. */
		vgic_update_state(vcpu->kvm);