Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc815c4b authored by Charles Keepax's avatar Charles Keepax Committed by Mark Brown
Browse files

ASoC: wm_adsp: Explicitly set the control access flags in all cases 



In the case where the firmware does not tell us the access flags for the
control, we let ALSA select a default (READWRITE). But really we should
be applying the volatile flag in this case, as we will read the control
from the DSP if it is on in this case. This patch explicitly sets the
access flags in all cases.

Signed-off-by: default avatarCharles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent c7dae7c4

sound/soc/codecs/wm_adsp.c

+3 −0
Original line number Diff line number Diff line
@@ -857,6 +857,9 @@ static int wmfw_add_ctl(struct wm_adsp *dsp, struct wm_coeff_ctl *ctl) 
			kcontrol->access |= SNDRV_CTL_ELEM_ACCESS_READ;

		if (ctl->flags & WMFW_CTL_FLAG_VOLATILE)

			kcontrol->access |= SNDRV_CTL_ELEM_ACCESS_VOLATILE;

	} else {

		kcontrol->access = SNDRV_CTL_ELEM_ACCESS_READWRITE;

		kcontrol->access |= SNDRV_CTL_ELEM_ACCESS_VOLATILE;

	}



	ret = snd_soc_add_card_controls(dsp->card,