Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc7e17ea authored by David S. Miller's avatar David S. Miller
Browse files

ipv4: Optimize flow initialization in fib_validate_source(). 



Like in commit 44713b67
("ipv4: Optimize flow initialization in output route lookup."
we can optimize the on-stack flow setup to only initialize
the members which are actually used.

Otherwise we bzero the entire structure, then initialize
explicitly the first half of it.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 67e28ffd

net/ipv4/fib_frontend.c

+9 −7
Original line number Diff line number Diff line
@@ -193,19 +193,21 @@ int fib_validate_source(__be32 src, __be32 dst, u8 tos, int oif, 
			u32 *itag, u32 mark)

{

	struct in_device *in_dev;

	struct flowi fl = {

		.fl4_dst = src,

		.fl4_src = dst,

		.fl4_tos = tos,

		.mark = mark,

		.iif = oif

	};

	struct flowi fl;

	struct fib_result res;

	int no_addr, rpf, accept_local;

	bool dev_match;

	int ret;

	struct net *net;



	fl.oif = 0;

	fl.iif = oif;

	fl.mark = mark;

	fl.fl4_dst = src;

	fl.fl4_src = dst;

	fl.fl4_tos = tos;

	fl.fl4_scope = RT_SCOPE_UNIVERSE;



	no_addr = rpf = accept_local = 0;

	in_dev = __in_dev_get_rcu(dev);

	if (in_dev) {