Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cc3593d3 authored by Joe Eykholt's avatar Joe Eykholt Committed by James Bottomley
Browse files

[SCSI] libfc: fix sequence-initiative WARN in fc_seq_start_next 



When starting a new response sequence in a multi-sequence
exchange, a warning was issued that sequence initiative
wasn't held.

The bug was that sequence initiative was cleared by the previous
sequence due to the END_SEQ flag being on.  The intent may have
been to check LAST_SEQ.  Change just to check SEQ_INIT.

Signed-off-by: default avatarJoe Eykholt <jeykholt@cisco.com>
Signed-off-by: default avatarRobert Love <robert.w.love@intel.com>
Signed-off-by: default avatarJames Bottomley <James.Bottomley@suse.de>
parent 42913657

drivers/scsi/libfc/fc_exch.c

+1 −1
Original line number Diff line number Diff line
@@ -488,7 +488,7 @@ static int fc_seq_send(struct fc_lport *lport, struct fc_seq *sp, 
	 */

	spin_lock_bh(&ep->ex_lock);

	ep->f_ctl = f_ctl & ~FC_FC_FIRST_SEQ;	/* not first seq */

	if (f_ctl & (FC_FC_END_SEQ | FC_FC_SEQ_INIT))

	if (f_ctl & FC_FC_SEQ_INIT)

		ep->esb_stat &= ~ESB_ST_SEQ_INIT;

	spin_unlock_bh(&ep->ex_lock);

	return error;