Commit cbfb3eaf authored Aug 20, 2019 by Wenwen Wang Committed by Greg Kroah-Hartman Sep 21, 2019

qed: Add cleanup in qed_slowpath_start()



[ Upstream commit de0e4fd2f07ce3bbdb69dfb8d9426b7227451b69 ]

If qed_mcp_send_drv_version() fails, no cleanup is executed, leading to
memory leaks. To fix this issue, introduce the label 'err4' to perform the
cleanup work before returning the error.

Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Acked-by: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent cd783b45

drivers/net/ethernet/qlogic/qed/qed_main.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -958,7 +958,7 @@ static int qed_slowpath_start(struct qed_dev *cdev,
		&drv_version);
		if (rc) {
		DP_NOTICE(cdev, "Failed sending drv version command\n");
		return rc;
		goto err4;
		}
		}

		@@ -966,6 +966,8 @@ static int qed_slowpath_start(struct qed_dev *cdev,

		return 0;

		err4:
		qed_ll2_dealloc_if(cdev);
		err3:
		qed_hw_stop(cdev);
		err2: