Commit cbca692c authored Mar 23, 2006 by Eric Sesterhenn Committed by Mark Fasheh Apr 10, 2006

[PATCH] Bogus NULL pointer check in fs/configfs/dir.c



We check the "group" pointer after we dereference it.  This check is
bogus, as it cannot be NULL coming in.

Signed-off-by: Joel Becker <joel.becker@oracle.com>
Signed-off-by: Mark Fasheh <mark.fasheh@oracle.com>

parent a9e2ae39

fs/configfs/dir.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -504,7 +504,7 @@ static int populate_groups(struct config_group *group)
		int ret = 0;
		int i;

		if (group && group->default_groups) {
		if (group->default_groups) {
		/* FYI, we're faking mkdir here
		* I'm not sure we need this semaphore, as we're called
		* from our parent's mkdir. That holds our parent's