Commit cba4c2ac authored Oct 31, 2011 by Masakazu Mokuno Committed by Linus Torvalds Oct 31, 2011

drivers/leds/led-triggers.c: fix memory leak



The memory for struct led_trigger should be kfreed in the
led_trigger_register() error path.  Also this function should return NULL
on error.

Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Cc: Richard Purdie <rpurdie@rpsys.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent f59b6f9f

drivers/leds/led-triggers.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -261,9 +261,12 @@ void led_trigger_register_simple(const char name, struct led_trigger *tp)
		if (trigger) {
		trigger->name = name;
		err = led_trigger_register(trigger);
		if (err < 0)
		if (err < 0) {
		kfree(trigger);
		trigger = NULL;
		printk(KERN_WARNING "LED trigger %s failed to register"
		" (%d)\n", name, err);
		}
		} else
		printk(KERN_WARNING "LED trigger %s failed to register"
		" (no memory)\n", name);