Commit cb0acb37 authored Nov 03, 2017 by Liu Bo Committed by Greg Kroah-Hartman Dec 20, 2017

badblocks: fix wrong return value in badblocks_set if badblocks are disabled




[ Upstream commit 39b4954c0a1556f8f7f1fdcf59a227117fcd8a0b ]

MD's rdev_set_badblocks() expects that badblocks_set() returns 1 if
badblocks are disabled, otherwise, rdev_set_badblocks() will record
superblock changes and return success in that case and md will fail to
report an IO error which it should.

This bug has existed since badblocks were introduced in commit
9e0e252a ("badblocks: Add core badblock management code").

Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Acked-by: Guoqing Jiang <gqjiang@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent dcdca123

block/badblocks.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -178,7 +178,7 @@ int badblocks_set(struct badblocks *bb, sector_t s, int sectors,

		if (bb->shift < 0)
		/* badblocks are disabled */
		return 0;
		return 1;

		if (bb->shift) {
		/* round the start down, and the end up */