Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit cb06d366 authored by Johan Hedberg's avatar Johan Hedberg Committed by Marcel Holtmann
Browse files

Bluetooth: Add clarifying comment when setting local OOB flag 



It might be a bit counterintuitive to set a 'local' flag based on remote
data. This patch adds a clarifying comment to the pairing req/rsp
handlers when setting the LOCAL_OOB flag based on the PDU received from
the remote side.

Signed-off-by: default avatarJohan Hedberg <johan.hedberg@intel.com>
Signed-off-by: default avatarMarcel Holtmann <marcel@holtmann.org>
parent a8ca617c

net/bluetooth/smp.c

+8 −0
Original line number Diff line number Diff line
@@ -1735,6 +1735,10 @@ static u8 smp_cmd_pairing_req(struct l2cap_conn *conn, struct sk_buff *skb) 
	memcpy(&smp->preq[1], req, sizeof(*req));

	skb_pull(skb, sizeof(*req));



	/* If the remote side's OOB flag is set it means it has

	 * successfully received our local OOB data - therefore set the

	 * flag to indicate that local OOB is in use.

	 */

	if (req->oob_flag == SMP_OOB_PRESENT)

		set_bit(SMP_FLAG_LOCAL_OOB, &smp->flags);
@@ -1902,6 +1906,10 @@ static u8 smp_cmd_pairing_rsp(struct l2cap_conn *conn, struct sk_buff *skb) 
	if (hci_dev_test_flag(hdev, HCI_SC_ONLY) && !(auth & SMP_AUTH_SC))

		return SMP_AUTH_REQUIREMENTS;



	/* If the remote side's OOB flag is set it means it has

	 * successfully received our local OOB data - therefore set the

	 * flag to indicate that local OOB is in use.

	 */

	if (rsp->oob_flag == SMP_OOB_PRESENT)

		set_bit(SMP_FLAG_LOCAL_OOB, &smp->flags);