Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit ca33fc77 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Sasha Levin
Browse files

iio: pressure: bmp280: Tolerate IRQ before registering 



[ Upstream commit 97b31a6f5fb95b1ec6575b78a7240baddba34384 ]

With DEBUG_SHIRQ enabled we have a kernel crash

[  116.482696] BUG: kernel NULL pointer dereference, address: 0000000000000000

...

[  116.606571] Call Trace:
[  116.609023]  <IRQ>
[  116.611047]  complete+0x34/0x50
[  116.614206]  bmp085_eoc_irq+0x9/0x10 [bmp280]

because DEBUG_SHIRQ mechanism fires an IRQ before registration and drivers
ought to be able to handle an interrupt happening before request_irq() returns.

Fixes: aae95394 ("iio: pressure: bmp280: add support for BMP085 EOC interrupt")
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 4b2abe8a

drivers/iio/pressure/bmp280-core.c

+4 −1
Original line number Diff line number Diff line
@@ -630,7 +630,7 @@ static int bmp180_measure(struct bmp280_data *data, u8 ctrl_meas) 
	unsigned int ctrl;



	if (data->use_eoc)

		init_completion(&data->done);

		reinit_completion(&data->done);



	ret = regmap_write(data->regmap, BMP280_REG_CTRL_MEAS, ctrl_meas);

	if (ret)
@@ -886,6 +886,9 @@ static int bmp085_fetch_eoc_irq(struct device *dev, 
			"trying to enforce it\n");

		irq_trig = IRQF_TRIGGER_RISING;

	}



	init_completion(&data->done);



	ret = devm_request_threaded_irq(dev,

			irq,

			bmp085_eoc_irq,