Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9dad805 authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Antonio Quartulli
Browse files

batman-adv: Use kref_get for batadv_tvlv_container_get 



batadv_tvlv_container_get requires that tvlv.container_list_lock is held by
the caller. It is therefore not possible that an item in
tvlv.container_list has an reference counter of 0 and is still in the list

The kref_get function instead WARNs (with debug information) when the
reference counter would still be 0. This makes a bug in batman-adv better
visible because kref_get_unless_zero would have ignored this problem.

Signed-off-by: default avatarSven Eckelmann <sven@narfation.org>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarAntonio Quartulli <a@unstable.cc>
parent d7d6de95

net/batman-adv/main.c

+1 −3
Original line number Diff line number Diff line
@@ -748,9 +748,7 @@ batadv_tvlv_container_get(struct batadv_priv *bat_priv, u8 type, u8 version) 
		if (tvlv_tmp->tvlv_hdr.version != version)

			continue;



		if (!kref_get_unless_zero(&tvlv_tmp->refcount))

			continue;



		kref_get(&tvlv_tmp->refcount);

		tvlv = tvlv_tmp;

		break;

	}