Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c97d9320 authored by Stephen Boyd's avatar Stephen Boyd Committed by David Brown
Browse files

ARM: msm: Drop useless teq from DEBUG_LL support



This teq was first introduced in bcc0f6af ([ARM] msm: clean up
iomap and devices, 2008-09-10). It seems that DEBUG_LL support on
MSM at the time had to remove the virtual mapping for the uart
base. Thus when the MMU was enabled the addruart macro returned 0
and the senduart macro would test for 0 and do nothing. It was a
simple way to turn off DEBUG_LL when the MMU was enabled.

The virtual mapping was added back in 6339f669 (msm: make
debugging UART (for DEBUG_LL) configurable, 2009-11-02) but the
patch forgot to remove the teq here. So as it stands the teq has
been useless for two years and DEBUG_LL works fine without it.

Cc: Nicolas Pitre <nico@fluxnic.net>
Signed-off-by: default avatarStephen Boyd <sboyd@codeaurora.org>
Signed-off-by: default avatarDavid Brown <davidb@codeaurora.org>
parent 00341028
Loading
Loading
Loading
Loading
+1 −2
Original line number Original line Diff line number Diff line
@@ -30,8 +30,7 @@
	@ Write the 1 character to UARTDM_TF
	@ Write the 1 character to UARTDM_TF
	str	\rd, [\rx, #0x70]
	str	\rd, [\rx, #0x70]
#else
#else
	teq	\rx, #0
	str	\rd, [\rx, #0x0C]
	strne	\rd, [\rx, #0x0C]
#endif
#endif
	.endm
	.endm