Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c9205697 authored by Greg Rose's avatar Greg Rose Committed by David S. Miller
Browse files

ixgbe: Allow the VF driver to be loaded before the PF driver 



The PF Reset Done bit should not be set in the extended control register
until the PF has actually completed the bring up process.  It is a mis-
interpretation of the purpose of this bit to assume it should be set
when the physical reset of the device is done.  Instead it should be used
to indicate to the VFs when the PF is ready to provide them with required
services.  This is not until after the PF is finished coming up and ready
to process mailbox events.

Signed-off-by: default avatarGreg Rose <gregory.v.rose@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ef291b8c

drivers/net/ixgbe/ixgbe_82599.c

+1 −5
Original line number Diff line number Diff line
@@ -890,7 +890,7 @@ static s32 ixgbe_setup_copper_link_82599(struct ixgbe_hw *hw, 
static s32 ixgbe_reset_hw_82599(struct ixgbe_hw *hw)

{

	s32 status = 0;

	u32 ctrl, ctrl_ext;

	u32 ctrl;

	u32 i;

	u32 autoc;

	u32 autoc2;
@@ -945,10 +945,6 @@ static s32 ixgbe_reset_hw_82599(struct ixgbe_hw *hw) 
		status = IXGBE_ERR_RESET_FAILED;

		hw_dbg(hw, "Reset polling failed to complete.\n");

	}

	/* Clear PF Reset Done bit so PF/VF Mail Ops can work */

	ctrl_ext = IXGBE_READ_REG(hw, IXGBE_CTRL_EXT);

	ctrl_ext |= IXGBE_CTRL_EXT_PFRSTD;

	IXGBE_WRITE_REG(hw, IXGBE_CTRL_EXT, ctrl_ext);



	msleep(50);

drivers/net/ixgbe/ixgbe_main.c

+7 −0
Original line number Diff line number Diff line
@@ -2826,6 +2826,7 @@ static int ixgbe_up_complete(struct ixgbe_adapter *adapter) 
	u32 txdctl, rxdctl, mhadd;

	u32 dmatxctl;

	u32 gpie;

	u32 ctrl_ext;



	ixgbe_get_hw_control(adapter);
@@ -3015,6 +3016,12 @@ static int ixgbe_up_complete(struct ixgbe_adapter *adapter) 
	adapter->flags |= IXGBE_FLAG_NEED_LINK_UPDATE;

	adapter->link_check_timeout = jiffies;

	mod_timer(&adapter->watchdog_timer, jiffies);



	/* Set PF Reset Done bit so PF/VF Mail Ops can work */

	ctrl_ext = IXGBE_READ_REG(hw, IXGBE_CTRL_EXT);

	ctrl_ext |= IXGBE_CTRL_EXT_PFRSTD;

	IXGBE_WRITE_REG(hw, IXGBE_CTRL_EXT, ctrl_ext);



	return 0;

}