Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c799443e authored by Markus Elfring's avatar Markus Elfring Committed by Antonio Quartulli
Browse files

batman-adv: Delete unnecessary checks before the function call "kfree_skb" 



The kfree_skb() function tests whether its argument is NULL and then
returns immediately. Thus the test around the calls is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: default avatarMarkus Elfring <elfring@users.sourceforge.net>
Signed-off-by: default avatarMarek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: default avatarAntonio Quartulli <a@unstable.cc>
parent d737ccbe

net/batman-adv/main.c

+1 −1
Original line number Diff line number Diff line
@@ -1184,7 +1184,7 @@ void batadv_tvlv_unicast_send(struct batadv_priv *bat_priv, u8 *src, 
		ret = true;



out:

	if (skb && !ret)

	if (!ret)

		kfree_skb(skb);

	if (orig_node)

		batadv_orig_node_free_ref(orig_node);

net/batman-adv/network-coding.c

+1 −3
Original line number Diff line number Diff line
@@ -244,9 +244,7 @@ static void batadv_nc_path_free_ref(struct batadv_nc_path *nc_path) 
 */

static void batadv_nc_packet_free(struct batadv_nc_packet *nc_packet)

{

	if (nc_packet->skb)

	kfree_skb(nc_packet->skb);



	batadv_nc_path_free_ref(nc_packet->nc_path);

	kfree(nc_packet);

}

net/batman-adv/send.c

+1 −2
Original line number Diff line number Diff line
@@ -407,7 +407,6 @@ void batadv_schedule_bat_ogm(struct batadv_hard_iface *hard_iface) 


static void batadv_forw_packet_free(struct batadv_forw_packet *forw_packet)

{

	if (forw_packet->skb)

	kfree_skb(forw_packet->skb);

	if (forw_packet->if_incoming)

		batadv_hardif_free_ref(forw_packet->if_incoming);