Commit c796984f authored Nov 17, 2011 by Thomas Meyer Committed by David S. Miller Nov 22, 2011

CDC NCM: Use kzalloc rather than kmalloc followed by memset with 0



This considers some simple cases that are common and easy to validate
Note in particular that there are no ...s in the rule, so all of the
matched code has to be contiguous

The semantic patch that makes this change is available
in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 26bff940

drivers/net/usb/cdc_ncm.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -465,12 +465,10 @@ static int cdc_ncm_bind(struct usbnet dev, struct usb_interface intf)
		int temp;
		u8 iface_no;

		ctx = kmalloc(sizeof(*ctx), GFP_KERNEL);
		ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
		if (ctx == NULL)
		return -ENODEV;

		memset(ctx, 0, sizeof(*ctx));

		init_timer(&ctx->tx_timer);
		spin_lock_init(&ctx->mtx);
		ctx->netdev = dev->net;