Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c7360b34 authored by Julia Lawall's avatar Julia Lawall Committed by Greg Kroah-Hartman
Browse files

xhci: drop null test before destroy functions 

Remove unneeded NULL test.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@ expression x; @@
-if (x != NULL)
  \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 03bce87c

drivers/usb/host/xhci-mem.c

+4 −8
Original line number Original line Diff line number Diff line
@@ -1828,23 +1828,19 @@ void xhci_mem_cleanup(struct xhci_hcd *xhci) 
	for (i = 1; i < MAX_HC_SLOTS; ++i)

	for (i = 1; i < MAX_HC_SLOTS; ++i)

		xhci_free_virt_device(xhci, i);

		xhci_free_virt_device(xhci, i);





	if (xhci->segment_pool)

	dma_pool_destroy(xhci->segment_pool);

	dma_pool_destroy(xhci->segment_pool);

	xhci->segment_pool = NULL;

	xhci->segment_pool = NULL;

	xhci_dbg_trace(xhci, trace_xhci_dbg_init, "Freed segment pool");

	xhci_dbg_trace(xhci, trace_xhci_dbg_init, "Freed segment pool");





	if (xhci->device_pool)

	dma_pool_destroy(xhci->device_pool);

	dma_pool_destroy(xhci->device_pool);

	xhci->device_pool = NULL;

	xhci->device_pool = NULL;

	xhci_dbg_trace(xhci, trace_xhci_dbg_init, "Freed device context pool");

	xhci_dbg_trace(xhci, trace_xhci_dbg_init, "Freed device context pool");





	if (xhci->small_streams_pool)

	dma_pool_destroy(xhci->small_streams_pool);

	dma_pool_destroy(xhci->small_streams_pool);

	xhci->small_streams_pool = NULL;

	xhci->small_streams_pool = NULL;

	xhci_dbg_trace(xhci, trace_xhci_dbg_init,

	xhci_dbg_trace(xhci, trace_xhci_dbg_init,

			"Freed small stream array pool");

			"Freed small stream array pool");





	if (xhci->medium_streams_pool)

	dma_pool_destroy(xhci->medium_streams_pool);

	dma_pool_destroy(xhci->medium_streams_pool);

	xhci->medium_streams_pool = NULL;

	xhci->medium_streams_pool = NULL;

	xhci_dbg_trace(xhci, trace_xhci_dbg_init,

	xhci_dbg_trace(xhci, trace_xhci_dbg_init,