Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c682e473 authored by Charan Teja Reddy's avatar Charan Teja Reddy
Browse files

iommu: disable smmu stalls on faulty transactions 



Disable the SMMU stalls on faulty transactions by terminating it using
the CB.SCTLR register. Faulty transaction on a CB causes the back
pressure on the QSMMU transaction pipe which inturn affect the other
masters using the same SMMU. Pass the DOMAIN_ATTR_CB_STALL_DISABLE flag
to iommu_domain_set_attr api in order to use this feature.

Change-Id: Ib8fa35854ff24e0295d330c5fb79375f58c3e841
Signed-off-by: default avatarCharan Teja Reddy <charante@codeaurora.org>
parent 41337d53

drivers/iommu/arm-smmu.c

+17 −0
Original line number Diff line number Diff line
@@ -250,6 +250,7 @@ enum arm_smmu_s2cr_privcfg { 


#define SCTLR_S1_ASIDPNE		(1 << 12)

#define SCTLR_CFCFG			(1 << 7)

#define SCTLR_HUPCF			(1 << 8)

#define SCTLR_CFIE			(1 << 6)

#define SCTLR_CFRE			(1 << 5)

#define SCTLR_E				(1 << 4)
@@ -1453,6 +1454,11 @@ static void arm_smmu_init_context_bank(struct arm_smmu_domain *smmu_domain, 
	/* SCTLR */

	reg = SCTLR_CFCFG | SCTLR_CFIE | SCTLR_CFRE | SCTLR_AFE | SCTLR_TRE;



	if (smmu_domain->attributes & (1 << DOMAIN_ATTR_CB_STALL_DISABLE)) {

		reg &= ~SCTLR_CFCFG;

		reg |= SCTLR_HUPCF;

	}



	if ((!(smmu_domain->attributes & (1 << DOMAIN_ATTR_S1_BYPASS)) &&

	     !(smmu_domain->attributes & (1 << DOMAIN_ATTR_EARLY_MAP))) ||

								!stage1)
@@ -2678,6 +2684,11 @@ static int arm_smmu_domain_get_attr(struct iommu_domain *domain, 
			& (1 << DOMAIN_ATTR_PAGE_TABLE_FORCE_COHERENT));

		ret = 0;

		break;

	case DOMAIN_ATTR_CB_STALL_DISABLE:

		*((int *)data) = !!(smmu_domain->attributes

			& (1 << DOMAIN_ATTR_CB_STALL_DISABLE));

		ret = 0;

		break;

	default:

		return -ENODEV;

	}
@@ -2855,6 +2866,12 @@ static int arm_smmu_domain_set_attr(struct iommu_domain *domain, 
		break;

	}



	case DOMAIN_ATTR_CB_STALL_DISABLE:

		if (*((int *)data))

			smmu_domain->attributes |=

				1 << DOMAIN_ATTR_CB_STALL_DISABLE;

		ret = 0;

		break;

	default:

		ret = -ENODEV;

	}

drivers/iommu/iommu-debug.c

+2 −0
Original line number Diff line number Diff line
@@ -71,6 +71,8 @@ static const char *iommu_debug_attr_to_string(enum iommu_attr attr) 
		return "DOMAIN_ATTR_FAST";

	case DOMAIN_ATTR_EARLY_MAP:

		return "DOMAIN_ATTR_EARLY_MAP";

	case DOMAIN_ATTR_CB_STALL_DISABLE:

		return "DOMAIN_ATTR_CB_STALL_DISABLE";

	default:

		return "Unknown attr!";

	}

include/linux/iommu.h

+1 −0
Original line number Diff line number Diff line
@@ -141,6 +141,7 @@ enum iommu_attr { 
	DOMAIN_ATTR_EARLY_MAP,

	DOMAIN_ATTR_PAGE_TABLE_IS_COHERENT,

	DOMAIN_ATTR_PAGE_TABLE_FORCE_COHERENT,

	DOMAIN_ATTR_CB_STALL_DISABLE,

	DOMAIN_ATTR_MAX,

};