Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c5e3035c authored by Alexander Gordeev's avatar Alexander Gordeev Committed by Jens Axboe
Browse files

skd: Fix out of array boundary access 



When enabling MSI-X, interrupts are requested for SKD_MAX_MSIX_COUNT
entries in skdev->msix_entries array, while the number of actually
allocated entries is skdev->msix_count. This might lead to an out of
boundary access in case number of allocated entries is less than
SKD_MAX_MSIX_COUNT. This update fixes the described misbehaviour.

Signed-off-by: default avatarAlexander Gordeev <agordeev@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: linux-pci@vger.kernel.org
Signed-off-by: default avatarJens Axboe <axboe@fb.com>
parent f219ad82

drivers/block/skd_main.c

+1 −1
Original line number Diff line number Diff line
@@ -3989,7 +3989,7 @@ static int skd_acquire_msix(struct skd_device *skdev) 
	}



	/* Enable MSI-X vectors for the base queue */

	for (i = 0; i < SKD_MAX_MSIX_COUNT; i++) {

	for (i = 0; i < skdev->msix_count; i++) {

		qentry = &skdev->msix_entries[i];

		snprintf(qentry->isr_name, sizeof(qentry->isr_name),

			 "%s%d-msix %s", DRV_NAME, skdev->devno,