Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c52a9554 authored by Steve French's avatar Steve French
Browse files

Don't compile in unused reparse point symlink code 



Recent Windows versions now create symlinks more frequently
and they do use this "reparse point" symlink mechanism.  We can of course
do symlinks nicely to Samba and other servers which support the
CIFS Unix Extensions and we can also do SFU symlinks and "client only"
"MF" symlinks optionally, but for recent Windows we currently can not
handle the common "reparse point" symlinks fully, removing the caller
for this. We will need to extend and reenable this "reparse point" worker
code in cifs and fix cifs_symlink to call this.  In the interim this code
has been moved to its own config option so it is not compiled in by default
until cifs_symlink fixed up (and tested) to use this.

CC: Jeff Layton <jlayton@redhat.com>
Signed-off-by: default avatarSteve French <sfrench@us.ibm.com>
parent 0eff0e26

fs/cifs/README

+0 −12
Original line number Diff line number Diff line
@@ -704,18 +704,6 @@ the start of smb requests and responses can be enabled via: 


	echo 1 > /proc/fs/cifs/traceSMB



Two other experimental features are under development. To test these

requires enabling CONFIG_CIFS_EXPERIMENTAL



	cifsacl support needed to retrieve approximated mode bits based on

		the contents on the CIFS ACL.



	lease support: cifs will check the oplock state before calling into

	the vfs to see if we can grant a lease on a file.



	DNOTIFY fcntl: needed for support of directory change 

			    notification and perhaps later for file leases)



Per share (per client mount) statistics are available in /proc/fs/cifs/Stats

if the kernel was configured with cifs statistics enabled.  The statistics

represent the number of successful (ie non-zero return code from the server)

fs/cifs/cifsproto.h

+2 −1
Original line number Diff line number Diff line
@@ -304,12 +304,13 @@ extern int CIFSSMBUnixQuerySymLink(const int xid, 
			struct cifsTconInfo *tcon,

			const unsigned char *searchName, char **syminfo,

			const struct nls_table *nls_codepage);

#ifdef CONFIG_CIFS_SYMLINK_EXPERIMENTAL

extern int CIFSSMBQueryReparseLinkInfo(const int xid,

			struct cifsTconInfo *tcon,

			const unsigned char *searchName,

			char *symlinkinfo, const int buflen, __u16 fid,

			const struct nls_table *nls_codepage);



#endif /* temporarily unused until cifs_symlink fixed */

extern int CIFSSMBOpen(const int xid, struct cifsTconInfo *tcon,

			const char *fileName, const int disposition,

			const int access_flags, const int omode,

fs/cifs/cifssmb.c

+12 −2
Original line number Diff line number Diff line
@@ -2516,7 +2516,17 @@ CIFSSMBUnixQuerySymLink(const int xid, struct cifsTconInfo *tcon, 
	return rc;

}



#ifdef CONFIG_CIFS_EXPERIMENTAL

#ifdef CONFIG_CIFS_SYMLINK_EXPERIMENTAL

/*

 *	Recent Windows versions now create symlinks more frequently

 *	and they use the "reparse point" mechanism below.  We can of course

 *	do symlinks nicely to Samba and other servers which support the

 *	CIFS Unix Extensions and we can also do SFU symlinks and "client only"

 *	"MF" symlinks optionally, but for recent Windows we really need to

 *	reenable the code below and fix the cifs_symlink callers to handle this.

 *	In the interim this code has been moved to its own config option so

 *	it is not compiled in by default until callers fixed up and more tested.

 */

int

CIFSSMBQueryReparseLinkInfo(const int xid, struct cifsTconInfo *tcon,

			const unsigned char *searchName,
@@ -2618,7 +2628,7 @@ CIFSSMBQueryReparseLinkInfo(const int xid, struct cifsTconInfo *tcon, 


	return rc;

}

#endif /* CIFS_EXPERIMENTAL */

#endif /* CIFS_SYMLINK_EXPERIMENTAL */ /* BB temporarily unused */



#ifdef CONFIG_CIFS_POSIX