Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c507de88 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Fix wrong gpio_dir & gpio_mask hint setups for IDT/STAC codecs 



stac_store_hints() does utterly wrong for masking the values for
gpio_dir and gpio_data, likely due to copy&paste errors.  Fortunately,
this feature is used very rarely, so the impact must be really small.

Reported-by: default avatarRasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 49cdd5b6

sound/pci/hda/patch_sigmatel.c

+2 −2
Original line number Diff line number Diff line
@@ -568,9 +568,9 @@ static void stac_store_hints(struct hda_codec *codec) 
			spec->gpio_mask;

	}

	if (get_int_hint(codec, "gpio_dir", &spec->gpio_dir))

		spec->gpio_mask &= spec->gpio_mask;

	if (get_int_hint(codec, "gpio_data", &spec->gpio_data))

		spec->gpio_dir &= spec->gpio_mask;

	if (get_int_hint(codec, "gpio_data", &spec->gpio_data))

		spec->gpio_data &= spec->gpio_mask;

	if (get_int_hint(codec, "eapd_mask", &spec->eapd_mask))

		spec->eapd_mask &= spec->gpio_mask;

	if (get_int_hint(codec, "gpio_mute", &spec->gpio_mute))