Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c4f79474 authored by Lina Iyer's avatar Lina Iyer
Browse files

drivers: qcom: rpmh: rename rpmh_write_passthru to rpmh_write_batch 



rpmh_write_passthru() was meant to be a call which did not cache the
RPMH requests in the driver. However, with some new optimizations, we
now cache even the requests sent as a batch through the passthru api.
Hence rename the api to rpmh_write_batch() to reflect the functionality.

Change-Id: Ib97f4cc80db415f4313fbb111faf23b002d4ca97
Signed-off-by: default avatarLina Iyer <ilina@codeaurora.org>
parent 1d9aee75

drivers/soc/qcom/msm_bus/msm_bus_fabric_rpmh.c

+3 −3
Original line number Diff line number Diff line
@@ -640,21 +640,21 @@ int msm_bus_commit_data(struct list_head *clist) 
			MSM_BUS_ERR("%s: error sending active/awake sets: %d\n",

						__func__, ret);

	} else {

		ret = rpmh_write_passthru(cur_mbox, cur_rsc->rscdev->req_state,

		ret = rpmh_write_batch(cur_mbox, cur_rsc->rscdev->req_state,

						cmdlist_active, n_active);

		if (ret)

			MSM_BUS_ERR("%s: error sending active/awake sets: %d\n",

						__func__, ret);

	}

	if (cnt_wake) {

		ret = rpmh_write_passthru(cur_mbox, RPMH_WAKE_ONLY_STATE,

		ret = rpmh_write_batch(cur_mbox, RPMH_WAKE_ONLY_STATE,

							cmdlist_wake, n_wake);

		if (ret)

			MSM_BUS_ERR("%s: error sending wake sets: %d\n",

							__func__, ret);

	}

	if (cnt_sleep) {

		ret = rpmh_write_passthru(cur_mbox, RPMH_SLEEP_STATE,

		ret = rpmh_write_batch(cur_mbox, RPMH_SLEEP_STATE,

							cmdlist_sleep, n_sleep);

		if (ret)

			MSM_BUS_ERR("%s: error sending sleep sets: %d\n",

drivers/soc/qcom/rpmh.c

+4 −3
Original line number Diff line number Diff line
@@ -591,7 +591,8 @@ static void invalidate_passthru(struct rpmh_client *rc) 
}



/**

 * rpmh_write_passthru: Write multiple batches of RPMH commands without caching

 * rpmh_write_batch: Write multiple sets of RPMH commands and wait for the

 * batch to finish.

 *

 * @rc: The RPMh handle got from rpmh_get_dev_channel

 * @state: Active/sleep set
@@ -606,7 +607,7 @@ static void invalidate_passthru(struct rpmh_client *rc) 
 *

 * May sleep. Do not call from atomic contexts for ACTIVE_ONLY requests.

 */

int rpmh_write_passthru(struct rpmh_client *rc, enum rpmh_state state,

int rpmh_write_batch(struct rpmh_client *rc, enum rpmh_state state,

			struct tcs_cmd *cmd, int *n)

{

	struct rpmh_msg *rpm_msg[RPMH_MAX_REQ_IN_BATCH] = { NULL };
@@ -695,7 +696,7 @@ int rpmh_write_passthru(struct rpmh_client *rc, enum rpmh_state state, 


	return 0;

}

EXPORT_SYMBOL(rpmh_write_passthru);

EXPORT_SYMBOL(rpmh_write_batch);



/**

 * rpmh_mode_solver_set: Indicate that the RSC controller hardware has

include/soc/qcom/rpmh.h

+2 −2
Original line number Diff line number Diff line
@@ -31,7 +31,7 @@ int rpmh_write(struct rpmh_client *rc, enum rpmh_state state, 
int rpmh_write_async(struct rpmh_client *rc, enum rpmh_state state,

			struct tcs_cmd *cmd, int n);



int rpmh_write_passthru(struct rpmh_client *rc, enum rpmh_state state,

int rpmh_write_batch(struct rpmh_client *rc, enum rpmh_state state,

			struct tcs_cmd *cmd, int *n);



int rpmh_mode_solver_set(struct rpmh_client *rc, bool enable);
@@ -70,7 +70,7 @@ static inline int rpmh_write_async(struct rpmh_client *rc, 
			enum rpmh_state state, struct tcs_cmd *cmd, int n)

{ return -ENODEV; }



static inline int rpmh_write_passthru(struct rpmh_client *rc,

static inline int rpmh_write_batch(struct rpmh_client *rc,

			enum rpmh_state state, struct tcs_cmd *cmd, int *n)

{ return -ENODEV; }