Commit c4f34226 authored Jan 05, 2013 by Nickolai Zeldovich Committed by Anton Vorontsov Jan 06, 2013

da9052-battery: Avoid out-of-range array access



Avoid accessing vc_tbl_ref[3], which is one past the end of that array, in
da9052_determine_vc_tbl_index(), by adjusting the loop bound.

(Hint: there is 'i + 1' inside the loop.)

Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
Signed-off-by: Anton Vorontsov <anton@enomsg.org>

parent 00edfc65

drivers/power/da9052-battery.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -337,7 +337,7 @@ static unsigned char da9052_determine_vc_tbl_index(unsigned char adc_temp)
		if (adc_temp > vc_tbl_ref[DA9052_VC_TBL_REF_SZ - 1])
		return DA9052_VC_TBL_REF_SZ - 1;

		for (i = 0; i < DA9052_VC_TBL_REF_SZ; i++) {
		for (i = 0; i < DA9052_VC_TBL_REF_SZ - 1; i++) {
		if ((adc_temp > vc_tbl_ref[i]) &&
		(adc_temp <= DA9052_MEAN(vc_tbl_ref[i], vc_tbl_ref[i + 1])))
		return i;