Commit c4c4ff82 authored Mar 22, 2022 by Jiapeng Chong Committed by Greg Kroah-Hartman Apr 27, 2022

platform/x86: samsung-laptop: Fix an unsigned comparison which can never be negative



[ Upstream commit 0284d4d1be753f648f28b77bdfbe6a959212af5c ]

Eliminate the follow smatch warnings:

drivers/platform/x86/samsung-laptop.c:1124 kbd_led_set() warn: unsigned
'value' is never less than zero.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/20220322061830.105579-1-jiapeng.chong@linux.alibaba.com


Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 9995aa5f

drivers/platform/x86/samsung-laptop.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1125,8 +1125,6 @@ static void kbd_led_set(struct led_classdev *led_cdev,

		if (value > samsung->kbd_led.max_brightness)
		value = samsung->kbd_led.max_brightness;
		else if (value < 0)
		value = 0;

		samsung->kbd_led_wk = value;
		queue_work(samsung->led_workqueue, &samsung->kbd_led_work);