Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c404f0de authored by Jan Kara's avatar Jan Kara Committed by Greg Kroah-Hartman
Browse files

ext4: fix fdatasync(2) after extent manipulation operations 



commit 67a7d5f561f469ad2fa5154d2888258ab8e6df7c upstream.

Currently, extent manipulation operations such as hole punch, range
zeroing, or extent shifting do not record the fact that file data has
changed and thus fdatasync(2) has a work to do. As a result if we crash
e.g. after a punch hole and fdatasync, user can still possibly see the
punched out data after journal replay. Test generic/392 fails due to
these problems.

Fix the problem by properly marking that file data has changed in these
operations.

Fixes: a4bb6b64
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 2e16921d

fs/ext4/extents.c

+5 −0
Original line number Diff line number Diff line
@@ -4887,6 +4887,8 @@ static long ext4_zero_range(struct file *file, loff_t offset, 


	/* Zero out partial block at the edges of the range */

	ret = ext4_zero_partial_blocks(handle, inode, offset, len);

	if (ret >= 0)

		ext4_update_inode_fsync_trans(handle, inode, 1);



	if (file->f_flags & O_SYNC)

		ext4_handle_sync(handle);
@@ -5573,6 +5575,7 @@ int ext4_collapse_range(struct inode *inode, loff_t offset, loff_t len) 
		ext4_handle_sync(handle);

	inode->i_mtime = inode->i_ctime = ext4_current_time(inode);

	ext4_mark_inode_dirty(handle, inode);

	ext4_update_inode_fsync_trans(handle, inode, 1);



out_stop:

	ext4_journal_stop(handle);
@@ -5746,6 +5749,8 @@ int ext4_insert_range(struct inode *inode, loff_t offset, loff_t len) 
	up_write(&EXT4_I(inode)->i_data_sem);

	if (IS_SYNC(inode))

		ext4_handle_sync(handle);

	if (ret >= 0)

		ext4_update_inode_fsync_trans(handle, inode, 1);



out_stop:

	ext4_journal_stop(handle);

fs/ext4/inode.c

+2 −0
Original line number Diff line number Diff line
@@ -4044,6 +4044,8 @@ int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length) 


	inode->i_mtime = inode->i_ctime = ext4_current_time(inode);

	ext4_mark_inode_dirty(handle, inode);

	if (ret >= 0)

		ext4_update_inode_fsync_trans(handle, inode, 1);

out_stop:

	ext4_journal_stop(handle);

out_dio: