Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c39c0be9 authored by Ivan Bornyakov's avatar Ivan Bornyakov Committed by Greg Kroah-Hartman
Browse files

nvme: host: core: fix precedence of ternary operator 



commit e9a9853c23c13a37546397b61b270999fd0fb759 upstream.

Ternary operator have lower precedence then bitwise or, so 'cdw10' was
calculated wrong.

Signed-off-by: default avatarIvan Bornyakov <brnkv.i1@gmail.com>
Reviewed-by: default avatarMax Gurtovoy <maxg@mellanox.com>
Signed-off-by: default avatarKeith Busch <keith.busch@intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5defd32b

drivers/nvme/host/core.c

+2 −2
Original line number Diff line number Diff line
@@ -1043,7 +1043,7 @@ static int nvme_pr_reserve(struct block_device *bdev, u64 key, 
static int nvme_pr_preempt(struct block_device *bdev, u64 old, u64 new,

		enum pr_type type, bool abort)

{

	u32 cdw10 = nvme_pr_type(type) << 8 | abort ? 2 : 1;

	u32 cdw10 = nvme_pr_type(type) << 8 | (abort ? 2 : 1);

	return nvme_pr_command(bdev, cdw10, old, new, nvme_cmd_resv_acquire);

}
@@ -1055,7 +1055,7 @@ static int nvme_pr_clear(struct block_device *bdev, u64 key) 


static int nvme_pr_release(struct block_device *bdev, u64 key, enum pr_type type)

{

	u32 cdw10 = nvme_pr_type(type) << 8 | key ? 1 << 3 : 0;

	u32 cdw10 = nvme_pr_type(type) << 8 | (key ? 1 << 3 : 0);

	return nvme_pr_command(bdev, cdw10, key, 0, nvme_cmd_resv_release);

}