Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c32649fe authored by Wu Fengguang's avatar Wu Fengguang Committed by Takashi Iwai
Browse files

ALSA: hda: read CORBWP inside reg_lock 



This converts the last CORBWP access outside of reg_lock.

Signed-off-by: default avatarWu Fengguang <fengguang.wu@intel.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent cdb1fbf2

sound/pci/hda/hda_intel.c

+3 −1
Original line number Diff line number Diff line
@@ -588,15 +588,17 @@ static int azx_corb_send_cmd(struct hda_bus *bus, u32 val) 
	unsigned int addr = azx_command_addr(val);

	unsigned int wp;



	spin_lock_irq(&chip->reg_lock);



	/* add command to corb */

	wp = azx_readb(chip, CORBWP);

	wp++;

	wp %= ICH6_MAX_CORB_ENTRIES;



	spin_lock_irq(&chip->reg_lock);

	chip->rirb.cmds[addr]++;

	chip->corb.buf[wp] = cpu_to_le32(val);

	azx_writel(chip, CORBWP, wp);



	spin_unlock_irq(&chip->reg_lock);



	return 0;