Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c3058579 authored by Joonyoung Shim's avatar Joonyoung Shim Committed by Inki Dae
Browse files

drm/exynos: remove buf_cnt from struct exynos_drm_fb 



Looking other drm drivers, there is no the restriction that framebuffer
has only one buffer in .create_handle() callback. They use just first
buffer.

If this limitation is removed, there is no reason keeping buffer count
for framebuffer, so we can remove buf_cnt from struct exynos_drm_fb.

Signed-off-by: default avatarJoonyoung Shim <jy0922.shim@samsung.com>
Reviewed-by: default avatarGustavo Padovan <gustavo.padovan@collabora.co.uk>
Signed-off-by: default avatarInki Dae <inki.dae@samsung.com>
parent faec262b

drivers/gpu/drm/exynos/exynos_drm_fb.c

+0 −9
Original line number Diff line number Diff line
@@ -32,12 +32,10 @@ 
 * exynos specific framebuffer structure.

 *

 * @fb: drm framebuffer obejct.

 * @buf_cnt: a buffer count to drm framebuffer.

 * @exynos_gem_obj: array of exynos specific gem object containing a gem object.

 */

struct exynos_drm_fb {

	struct drm_framebuffer		fb;

	unsigned int			buf_cnt;

	struct exynos_drm_gem_obj	*exynos_gem_obj[MAX_FB_BUFFER];

};
@@ -97,10 +95,6 @@ static int exynos_drm_fb_create_handle(struct drm_framebuffer *fb, 
{

	struct exynos_drm_fb *exynos_fb = to_exynos_fb(fb);



	/* This fb should have only one gem object. */

	if (WARN_ON(exynos_fb->buf_cnt != 1))

		return -EINVAL;



	return drm_gem_handle_create(file_priv,

			&exynos_fb->exynos_gem_obj[0]->base, handle);

}
@@ -135,9 +129,6 @@ exynos_drm_framebuffer_init(struct drm_device *dev, 
	if (!exynos_fb)

		return ERR_PTR(-ENOMEM);



	exynos_fb->buf_cnt = count;

	DRM_DEBUG_KMS("buf_cnt = %d\n", exynos_fb->buf_cnt);



	for (i = 0; i < count; i++) {

		ret = check_fb_gem_memory_type(dev, gem_obj[i]);

		if (ret < 0)