Commit c2ff861d authored Sep 17, 2012 by Peter Senna Tschudin Committed by Herbert Xu Sep 27, 2012

crypto: hifn_795x - fix error return code

Convert a nonnegative error return code to a negative one, as returned
elsewhere in the function.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent 79c09c12

drivers/crypto/hifn_795x.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -2611,14 +2611,17 @@ static int __devinit hifn_probe(struct pci_dev *pdev, const struct pci_device_id
		size = pci_resource_len(pdev, i);

		dev->bar[i] = ioremap_nocache(addr, size);
		if (!dev->bar[i])
		if (!dev->bar[i]) {
		err = -ENOMEM;
		goto err_out_unmap_bars;
		}
		}

		dev->desc_virt = pci_alloc_consistent(pdev, sizeof(struct hifn_dma),
		&dev->desc_dma);
		if (!dev->desc_virt) {
		dprintk("Failed to allocate descriptor rings.\n");
		err = -ENOMEM;
		goto err_out_unmap_bars;
		}
		memset(dev->desc_virt, 0, sizeof(struct hifn_dma));