Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2ccc084 authored by Chuck Lever's avatar Chuck Lever Committed by Trond Myklebust
Browse files

NFS: nfs41_walk_client_list(): re-lock before iterating 



Sparse identified an execution path in nfs41_walk_client_list()
where the nfs_client_lock is not re-acquired before taking the next
loop iteration.

fs/nfs/nfs4client.c:437:9: sparse: context imbalance in
 'nfs41_walk_client_list' - different lock contexts for basic block

Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
Cc: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: default avatarTrond Myklebust <Trond.Myklebust@netapp.com>
parent ee314c2a

fs/nfs/nfs4client.c

+1 −0
Original line number Diff line number Diff line
@@ -450,6 +450,7 @@ int nfs41_walk_client_list(struct nfs_client *new, 
			error = nfs_wait_client_init_complete(pos);

			if (error < 0) {

				nfs_put_client(pos);

				spin_lock(&nn->nfs_client_lock);

				continue;

			}