Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c2a0531f authored by Liang Chen's avatar Liang Chen Committed by Greg Kroah-Hartman
Browse files

bcache: explicitly destroy mutex while exiting 




[ Upstream commit 330a4db89d39a6b43f36da16824eaa7a7509d34d ]

mutex_destroy does nothing most of time, but it's better to call
it to make the code future proof and it also has some meaning
for like mutex debug.

As Coly pointed out in a previous review, bcache_exit() may not be
able to handle all the references properly if userspace registers
cache and backing devices right before bch_debug_init runs and
bch_debug_init failes later. So not exposing userspace interface
until everything is ready to avoid that issue.

Signed-off-by: default avatarLiang Chen <liangchen.linux@gmail.com>
Reviewed-by: default avatarMichael Lyle <mlyle@lyle.org>
Reviewed-by: default avatarColy Li <colyli@suse.de>
Reviewed-by: default avatarEric Wheeler <bcache@linux.ewheeler.net>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarSasha Levin <alexander.levin@verizon.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 75f66eea

drivers/md/bcache/super.c

+4 −2
Original line number Diff line number Diff line
@@ -2091,6 +2091,7 @@ static void bcache_exit(void) 
	if (bcache_major)

		unregister_blkdev(bcache_major, "bcache");

	unregister_reboot_notifier(&reboot);

	mutex_destroy(&bch_register_lock);

}



static int __init bcache_init(void)
@@ -2109,14 +2110,15 @@ static int __init bcache_init(void) 
	bcache_major = register_blkdev(0, "bcache");

	if (bcache_major < 0) {

		unregister_reboot_notifier(&reboot);

		mutex_destroy(&bch_register_lock);

		return bcache_major;

	}



	if (!(bcache_wq = alloc_workqueue("bcache", WQ_MEM_RECLAIM, 0)) ||

	    !(bcache_kobj = kobject_create_and_add("bcache", fs_kobj)) ||

	    sysfs_create_files(bcache_kobj, files) ||

	    bch_request_init() ||

	    bch_debug_init(bcache_kobj))

	    bch_debug_init(bcache_kobj) ||

	    sysfs_create_files(bcache_kobj, files))

		goto err;



	return 0;