Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c232d8a8 authored by Tony Camuso's avatar Tony Camuso Committed by David S. Miller
Browse files

netxen_nic: use spin_[un]lock_bh around tx_clean_lock 



While testing this driver with DEBUG_LOCKDEP and DEBUG_SPINLOCK
enabled did not produce any traces, it would be more prudent in the
case of tx_clean_lock to use spin_[un]lock_bh, since this lock is
manipulated in both the process and softirq contexts.

This patch was tested for functionality and regressions with netperf
and DEBUG_LOCKDEP and DEBUG_SPINLOCK enabled.

Signed-off-by: default avatarTony Camuso <tcamuso@redhat.com>
Acked-by: default avatarNeil Horman <nhorman@tuxdriver.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 17d5ceb6

drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c

+2 −2
Original line number Diff line number Diff line
@@ -135,7 +135,7 @@ void netxen_release_tx_buffers(struct netxen_adapter *adapter) 
	int i, j;

	struct nx_host_tx_ring *tx_ring = adapter->tx_ring;



	spin_lock(&adapter->tx_clean_lock);

	spin_lock_bh(&adapter->tx_clean_lock);

	cmd_buf = tx_ring->cmd_buf_arr;

	for (i = 0; i < tx_ring->num_desc; i++) {

		buffrag = cmd_buf->frag_array;
@@ -159,7 +159,7 @@ void netxen_release_tx_buffers(struct netxen_adapter *adapter) 
		}

		cmd_buf++;

	}

	spin_unlock(&adapter->tx_clean_lock);

	spin_unlock_bh(&adapter->tx_clean_lock);

}



void netxen_free_sw_resources(struct netxen_adapter *adapter)