Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c1edff5b authored by Davide Caratti's avatar Davide Caratti Committed by Greg Kroah-Hartman
Browse files

net/sched: flower: add missing validation of TCA_FLOWER_FLAGS 



[ Upstream commit e2debf0852c4d66ba1a8bde12869b196094c70a7 ]

unlike other classifiers that can be offloaded (i.e. users can set flags
like 'skip_hw' and 'skip_sw'), 'cls_flower' doesn't validate the size of
netlink attribute 'TCA_FLOWER_FLAGS' provided by user: add a proper entry
to fl_policy.

Fixes: 5b33f488 ("net/flower: Introduce hardware offload support")
Signed-off-by: default avatarDavide Caratti <dcaratti@redhat.com>
Acked-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9afbff69

net/sched/cls_flower.c

+1 −0
Original line number Diff line number Diff line
@@ -364,6 +364,7 @@ static const struct nla_policy fl_policy[TCA_FLOWER_MAX + 1] = { 
	[TCA_FLOWER_KEY_TCP_DST_MASK]	= { .type = NLA_U16 },

	[TCA_FLOWER_KEY_UDP_SRC_MASK]	= { .type = NLA_U16 },

	[TCA_FLOWER_KEY_UDP_DST_MASK]	= { .type = NLA_U16 },

	[TCA_FLOWER_FLAGS]		= { .type = NLA_U32 },

};



static void fl_set_key_val(struct nlattr **tb,