Commit c1cd1497 authored Jan 13, 2014 by Malcolm Priestley Committed by Greg Kroah-Hartman Jan 13, 2014

staging: vt6656: sparse fixes: iwctl_giwgenie use memcpy.



extra is in kernel space use memcpy.

sparse warning
iwctl.c:1595:42: warning: incorrect type in argument 1 (different address spaces)
iwctl.c:1595:42:    expected void [noderef] <asn:1>*to
iwctl.c:1595:42:    got char *extra

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9010a286

drivers/staging/vt6656/iwctl.c

+4 −6

Original line number	Diff line number	Diff line
		@@ -1591,14 +1591,12 @@ int iwctl_giwgenie(struct net_device dev, struct iw_request_info info,
		wrq->length = 0;
		if (pMgmt->wWPAIELen > 0) {
		wrq->length = pMgmt->wWPAIELen;
		if (pMgmt->wWPAIELen <= space) {
		if (copy_to_user(extra, pMgmt->abyWPAIE, pMgmt->wWPAIELen)) {
		ret = -EFAULT;
		}
		} else {

		if (pMgmt->wWPAIELen <= space)
		memcpy(extra, pMgmt->abyWPAIE, pMgmt->wWPAIELen);
		else
		ret = -E2BIG;
		}
		}
		return ret;
		}