Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c17c3cdf authored by Liping Zhang's avatar Liping Zhang Committed by Pablo Neira Ayuso
Browse files

netfilter: nf_tables: destroy the set if fail to add transaction 



When the memory is exhausted, then we will fail to add the NFT_MSG_NEWSET
transaction. In such case, we should destroy the set before we free it.

Fixes: 958bee14 ("netfilter: nf_tables: use new transaction infrastructure to handle sets")
Signed-off-by: default avatarLiping Zhang <zlpnobody@gmail.com>
Signed-off-by: default avatarPablo Neira Ayuso <pablo@netfilter.org>
parent 57476202

net/netfilter/nf_tables_api.c

+3 −1
Original line number Diff line number Diff line
@@ -2956,12 +2956,14 @@ static int nf_tables_newset(struct net *net, struct sock *nlsk, 


	err = nft_trans_set_add(&ctx, NFT_MSG_NEWSET, set);

	if (err < 0)

		goto err2;

		goto err3;



	list_add_tail_rcu(&set->list, &table->sets);

	table->use++;

	return 0;



err3:

	ops->destroy(set);

err2:

	kfree(set);

err1: