Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c17893c7 authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: add a test for const with __read_mostly uses 



const objects shouldn't be __read_mostly.  They are read-only.

Marking these objects as __read_mostly causes section conflicts with LTO
linking.

So add a test to try to avoid this issue.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@shadowen.org>
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d7fe8065

scripts/checkpatch.pl

+10 −0
Original line number Diff line number Diff line
@@ -4791,6 +4791,16 @@ sub process { 
			}

		}



# check for __read_mostly with const non-pointer (should just be const)

		if ($line =~ /\b__read_mostly\b/ &&

		    $line =~ /($Type)\s*$Ident/ && $1 !~ /\*\s*$/ && $1 =~ /\bconst\b/) {

			if (ERROR("CONST_READ_MOSTLY",

				  "Invalid use of __read_mostly with const type\n" . $herecurr) &&

			    $fix) {

				$fixed[$fixlinenr] =~ s/\s+__read_mostly\b//;

			}

		}



# don't use __constant_<foo> functions outside of include/uapi/

		if ($realfile !~ m@^include/uapi/@ &&

		    $line =~ /(__constant_(?:htons|ntohs|[bl]e(?:16|32|64)_to_cpu|cpu_to_[bl]e(?:16|32|64)))\s*\(/) {