Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c164154f authored by Lorenzo Stoakes's avatar Lorenzo Stoakes Committed by Linus Torvalds
Browse files

mm: replace get_user_pages_unlocked() write/force parameters with gup_flags 



This removes the 'write' and 'force' use from get_user_pages_unlocked()
and replaces them with 'gup_flags' to make the use of FOLL_FORCE
explicit in callers as use of this flag can result in surprising
behaviour (and hence bugs) within the mm subsystem.

Signed-off-by: default avatarLorenzo Stoakes <lstoakes@gmail.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Acked-by: default avatarMichal Hocko <mhocko@suse.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent d4944b0e

arch/mips/mm/gup.c

+1 −1
Original line number Diff line number Diff line
@@ -287,7 +287,7 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write, 
	pages += nr;



	ret = get_user_pages_unlocked(start, (end - start) >> PAGE_SHIFT,

				      write, 0, pages);

				      pages, write ? FOLL_WRITE : 0);



	/* Have to be a bit careful with return values */

	if (nr > 0) {

arch/s390/mm/gup.c

+2 −1
Original line number Diff line number Diff line
@@ -266,7 +266,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write, 
	/* Try to get the remaining pages with get_user_pages */

	start += nr << PAGE_SHIFT;

	pages += nr;

	ret = get_user_pages_unlocked(start, nr_pages - nr, write, 0, pages);

	ret = get_user_pages_unlocked(start, nr_pages - nr, pages,

				      write ? FOLL_WRITE : 0);

	/* Have to be a bit careful with return values */

	if (nr > 0)

		ret = (ret < 0) ? nr : ret + nr;

arch/sh/mm/gup.c

+2 −1
Original line number Diff line number Diff line
@@ -258,7 +258,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write, 
		pages += nr;



		ret = get_user_pages_unlocked(start,

			(end - start) >> PAGE_SHIFT, write, 0, pages);

			(end - start) >> PAGE_SHIFT, pages,

			write ? FOLL_WRITE : 0);



		/* Have to be a bit careful with return values */

		if (nr > 0) {

arch/sparc/mm/gup.c

+2 −1
Original line number Diff line number Diff line
@@ -238,7 +238,8 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write, 
		pages += nr;



		ret = get_user_pages_unlocked(start,

			(end - start) >> PAGE_SHIFT, write, 0, pages);

			(end - start) >> PAGE_SHIFT, pages,

			write ? FOLL_WRITE : 0);



		/* Have to be a bit careful with return values */

		if (nr > 0) {

arch/x86/mm/gup.c

+1 −1
Original line number Diff line number Diff line
@@ -435,7 +435,7 @@ int get_user_pages_fast(unsigned long start, int nr_pages, int write, 


		ret = get_user_pages_unlocked(start,

					      (end - start) >> PAGE_SHIFT,

					      write, 0, pages);

					      pages, write ? FOLL_WRITE : 0);



		/* Have to be a bit careful with return values */

		if (nr > 0) {